Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueman-manager: plugins dialog race #383

Closed
latot opened this issue Nov 2, 2015 · 8 comments
Closed

blueman-manager: plugins dialog race #383

latot opened this issue Nov 2, 2015 · 8 comments
Labels

Comments

@latot
Copy link
Contributor

latot commented Nov 2, 2015

Hi again, mm, first the log:

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/blueman/gui/manager/ManagerMenu.py", line 92, in <lambda>
    item.connect('activate', lambda *args: self.blueman.Applet.open_plugin_dialog())
  File "/usr/lib64/python2.7/site-packages/dbus/proxies.py", line 145, in __call__
    **keywords)
  File "/usr/lib64/python2.7/site-packages/dbus/connection.py", line 651, in call_blocking
    message, timeout)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.

basically this happend when you open first blueman-manager and then open the plugin windows, the close the main windows and there is the error, probably this can be fixed closing the secondary windows with the main.

Distr: Gentoo 64 (9999 ebuild)
BlueZ: 5.35

Thx all.

@infirit infirit added the bug label Nov 2, 2015
@infirit
Copy link
Contributor

infirit commented Nov 2, 2015

Confirmed, but the problem is that blueman-manager is blocked and you can just wait ~60 seconds and it will show up. Not sure why this is, can you try net-wireless/blueman-2.0-r1 and check if you see the same?

@latot
Copy link
Contributor Author

latot commented Nov 2, 2015

testing... testing...
okis, this happend in the 2.0-r1
practically the problem is closing the main windows don't close the secondaries.
tecnically the error message, in fact if we wait a little after click close the main windows it close and we get the message.

@cschramm
Copy link
Member

cschramm commented Nov 3, 2015

I guess the issue is that the ManagerMenu waits for a reply from the applet's open_plugin_dialog method as the result is used as the result of the lambda although it is actually dropped and that method blocks on dialog.run() until the dialog is closed. Either the lambda or the open_plugin_dialog method should not block to avoid this.

@infirit
Copy link
Contributor

infirit commented Nov 3, 2015

Merging the details from #384 as this is the same problem.

Hi, rethinking this issue, basically blueman-manager don't load the info of the plugins, and it was right, if i open the plugins from the blueman-applet seems works.
i'm checking other things for now..

@latot
Copy link
Contributor Author

latot commented Nov 3, 2015

uu, hi, i like this message, opening the pluging's windows

Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.

@infirit infirit changed the title dbus.exceptions.DBusException -- multiples windows blueman-manager: plugins dialog race Nov 3, 2015
@infirit
Copy link
Contributor

infirit commented Nov 3, 2015

@cschramm, would executing the function over dbus help? I see it is exposed by org.blueman.Applet (I am very bad with dbus so don't ask me how 😄)

@cschramm
Copy link
Member

cschramm commented Nov 3, 2015

It's already called via dbus (there's no other way for the manager to talk to the applet), but up to now the call was synchronous. Fixed that. Please test.

@latot
Copy link
Contributor Author

latot commented Nov 3, 2015

yay now works, the only thing, when i open the plugins from the applet now works load the info, but now i can't reproduce it, well, little weird, anyway.
Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants