Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on signal bars #860

Open
infirit opened this issue Apr 15, 2018 · 5 comments
Open

Decide on signal bars #860

infirit opened this issue Apr 15, 2018 · 5 comments

Comments

@infirit
Copy link
Contributor

infirit commented Apr 15, 2018

With bluetooth LE we do not have signal bars. The problem afaics is that we do not have tpl, lq and rss. We do have an rssi property in the dbus api but it is only available during discovery.

While it has been a big part of blueman the simplest would be drop them and instead have an indicator showing if the device is connected. I can add the indicator on top of the bars as well but this will make the ui inconsistent between LE and non LE devices.

Opinions, suggestions, complaints :-)

@stale
Copy link

stale bot commented Apr 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 20, 2019
@infirit infirit added enhancement and removed stale labels Apr 20, 2019
@infirit infirit mentioned this issue Oct 11, 2019
3 tasks
@cschramm
Copy link
Member

My opinions on this:

  • Connection indicator definitely makes sense
  • Inconsistent UI between LE and non LE is fine

The only way to avoid the inconsistency seems to be to not use the information we have for non LE devices. The signal bars are probably not that useful to most users, but I'd not downgrade that UI for consistency reasons.

@infirit
Copy link
Contributor Author

infirit commented Nov 7, 2020

I used an image upscaler (waify2x) and the result is pretty good. Imho this looks good enough for Gdk scaling. I'll do them all tomorrow and test it out.
blueman-lq-90_waifu2x_art_scale_tta_1

@infirit
Copy link
Contributor Author

infirit commented Nov 8, 2020

Here is the result with GDK_SCALE=2. It is pretty amazing how well this ai upscaler works 😲 . I'll open a PR for this.

afbeelding

@cschramm cschramm added this to the 2.4 milestone Jun 29, 2022
@infirit
Copy link
Contributor Author

infirit commented Jul 25, 2022

I'm leaning towards using using a Gtk.LevelBar as seen in #1768. But this requires quite a bit of work replacing the TreeView.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants