Caution on sampleids coercable to integers

[nickp60]

Hello! This is a minor edge case but I'm posting in case anyone else runs into the issue. In cases where the given sample name consists of digits, it appears that pandas is coercing the column to integers, which breaks the logic here with an error:

    out = sample_file.split('/')[-1]
          ^^^^^^^^^^^^^^^^^
AttributeError: 'int' object has no attribute 'split'

I think adding something like the following should sort it out.

            df = pd.read_csv(sylph_result, sep='\t')
            df.sample_name = df.sample_name.astype(str)

Thanks for all your efforts!

Nick

[bluenote-1577]

Hi Nick,

Thanks for catching this. I can reproduce the bug and have added a fix as you've suggested:

df['Sample_file'] = df['Sample_file'].astype(str)

Pushing a new version now -- you may have to do pip install sylph-tax/ on the cloned version since it won't be on conda right away.

P.S. this is why I hate python...

Thanks