Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restart recordings in case of errors (#2439) #2571

Merged
merged 1 commit into from
Oct 26, 2023
Merged

restart recordings in case of errors (#2439) #2571

merged 1 commit into from
Oct 26, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Oct 26, 2023

Fixes #2439

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2571 (26e0956) into main (28452ac) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main    #2571      +/-   ##
==========================================
- Coverage   59.64%   59.63%   -0.01%     
==========================================
  Files         144      145       +1     
  Lines       15496    15512      +16     
==========================================
+ Hits         9243     9251       +8     
- Misses       5601     5608       +7     
- Partials      652      653       +1
Files Coverage Δ
internal/core/path.go 73.36% <100.00%> (-0.55%) ⬇️
internal/record/agent_instance.go 100.00% <100.00%> (ø)
internal/record/rec_format_fmp4_part.go 79.68% <100.00%> (ø)
internal/record/rec_format_fmp4_track.go 81.25% <100.00%> (ø)
internal/record/rec_format_mpegts_segment.go 85.36% <100.00%> (ø)
internal/record/rec_format_fmp4_segment.go 76.47% <66.66%> (ø)
internal/record/agent.go 86.48% <87.87%> (-7.86%) ⬇️
internal/record/rec_format_mpegts.go 37.44% <53.84%> (-0.06%) ⬇️
internal/record/rec_format_fmp4.go 26.42% <40.00%> (-0.11%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aler9 aler9 merged commit 3ebc585 into main Oct 26, 2023
7 of 8 checks passed
@aler9 aler9 deleted the bug/record branch October 26, 2023 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encode errors cause recordings to stop without retries
1 participant
@aler9