Upstream Tor Project Bugs

[morganava]

A collection of upstream bugs so we don't lose them

Open Blockers

These issues need to be addressed for full arti-client TorProvider support

• arti

  • proxy.socks_listen should support auto
  • arti bootstraps automatically on launch

• arti-client

  • Global tracing_subscriber-based logging (probably) has no way to filter based on arti-client instance

Open Misc

These are issues we can work around and are not blockers for our functionality

• tor-llcrypto
  • tor_llcrypto::pk::ed25519::ExpandedSecretKey::from_bytes() accepts byte buffers which are somehow invalid private keys
  • tor-llcrypto's pk::ed25519::ExpandedKeypair does not implement clone()
• arti-client
  • BootstrapStatus has no 'tag' or 'summary' analogues
  • Perhaps strange OnionService::launch(...) returns an Arc
  • StreamParameters API doesn't provide a good way to say "make sure that IPv6-only addresses will work"
• arti
  • Implement arti equivalent of c-tor's __OwningControllerProcess
  • bundled arti needs some way to communicate the conneciton string to parent application
  • arti does not seem to have a way to signal to parent application that its ready for rpc connections
  • arti stdout is coloured (presumably with ANSI escape codes?) even when not run from a terminal
  • Cannot connect to RPC endpoint when unix socket lives in /tmp
    • the workaround here is to chmod arti's data directory to 0o700 (i.e. make it non-world writable)
  • TCP RPC endpoint requires user to specify listening port

Resolved

• tor-llcrypto 0.7.0 ed25519 apis seemingly incompatible with version 0.4.0
• Various road-blocks for implementing a custom KeyStore type
• Perhaps no way to determine when an Onion Service has been published
  • Fixed in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2086
• Add service config for enabling client authorization ("restricted mode")
• BootstrapStatus::ready_for_traffic doesn't seem to ever return true
  
• DataWriter.flush(); circuit.terminate(); does not behave as one would expect (race condition?)
• DataReader read_to_end() does not return when the associated DataWriter is shutdown()
• Including bson crate in binary with arti-client breaks bootstrap
  • Fixed in https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2462
• "Cooked" onion service APIs
• arti-rpc-client-core does not support Windows
  • arti now supports TCP endpoints