Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLatestCommit on Relay returns 500 for (some?) deleted accounts #621

Open
mackuba opened this issue Mar 15, 2024 · 3 comments
Open

getLatestCommit on Relay returns 500 for (some?) deleted accounts #621

mackuba opened this issue Mar 15, 2024 · 3 comments
Labels
bug Something isn't working correctness Core protocol and data storage issues

Comments

@mackuba
Copy link

mackuba commented Mar 15, 2024

https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:pkmfz5soq2swsvbhvjekb36g
https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:ravrgr24ltd5oxft2mha6chc
https://bsky.network/xrpc/com.atproto.sync.getLatestCommit?did=did:plc:cw2oqmrjzpfaezhs6pp3bksy

HTTP/2 500 
vary: Origin
date: Fri, 15 Mar 2024 22:17:37 GMT
content-length: 0
strict-transport-security: max-age=63072000

The first one is a DID from an independent PDS where the owner (IIRC) has manually added a plc_tombstone operation to PLC because they thought it was needed. The second one is also a repo on another independent PDS, the repo doesn't seem to exist on the PDS anymore.

The third was a DID on a Bluesky PDS, so I'm assuming this might actually be happening for all deleted repos?

@mackuba
Copy link
Author

mackuba commented Mar 25, 2024

More examples:

did:plc:icjkfdhae2trwtx3ikmv62ii (maitake.us-west.host.bsky.network)
did:plc:5voyzxlltvyvfzw5umluvfu5 (bsky.gdgd.tokyo)
did:plc:g6klig5oawtvtqb7qnuyhhwb (bsky.gdgd.tokyo)

@bnewbold
Copy link
Collaborator

Thanks for reporting these! Sorry to leave these lingering.

We are planning to iterate on how identity and account lifecycle events are transmitted over the repo event stream ("firehose"), most likely deprecating the #handle and #tombstone events to use just #identity and #account. When we do that, the relay will be updated to have slightly different internal account state tracking. I think that we'll probably wait to debug these accounts until we do that update, and then ensure/test that tombstoned accounts are handled consistently.

@mackuba
Copy link
Author

mackuba commented Jul 20, 2024

FYI, this is still happening on some subset of accounts (I don't know what the specific trigger is):

Missing (deleted):

did:plc:2sd52mgbhe4zueb6ox2b2stw
did:plc:323cun25gk6dws7nj7qlsnwq
did:plc:dnedzjua6fvq7kctz2ngjyqg
did:plc:en5fqaesnxmnvbv3rd7pf4dg
did:plc:kw2pw4m5i6qdvf75zl6xnda6
did:plc:n3ssko3gyx5xyxdjq6zjibel
did:plc:nr22d6zfekv6lmlelslx724a
did:plc:snjqn5vwnacw23bqcajjcncf
did:plc:spcpkkqrsjjkheik7hiase5g
did:plc:xuqj2wyfwscj6ese7uz25vbm

Deactivated:

did:plc:4hr5aknimbkgrwck2yavd4nr
did:plc:53rhoo334cwlwdtkhkjfcnsf
did:plc:b7h76rxjbsuvnsd7r5tjqxvu
did:plc:hlrbzz6nnmqnum6n47uv6ss3
did:plc:hmkew6ezufskohs7uouejpox
did:plc:njq3obw3mdspy5kgput76crg
did:plc:nuulxhabdwtestmlmyyvdk4s
did:plc:qr7yo4a5hpyyalnpr5fobsc2
did:plc:rlgy5p7jbetzrhapdiiexrg6
did:plc:tw3tfznvszlvuvi2bvfe7imk
did:plc:u5ujeh2lwem3xbusygab47jx
did:plc:v3utt5dopoqpa6s45p5pkco4
did:plc:y2azxakhs4rdcolqfgyn42of

Taken down:

did:plc:bfve4p2np75b5lrw7dxer2mr
did:plc:bl2acgcms4yabeifff3jfqux
did:plc:nscz33ecrnli5bg2uvyhwtyp
did:plc:p2joiced5seqix4w2e7ziw2j
did:plc:qikmswmv2uaxwhxl2o64lzwz

@bnewbold bnewbold added bug Something isn't working correctness Core protocol and data storage issues labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctness Core protocol and data storage issues
Projects
None yet
Development

No branches or pull requests

2 participants