New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sim_motor _move not moving in the correct direction with negative value. #476

Closed

Relm-Arrowny opened this issue Jul 23, 2024 · 0 comments · Fixed by #670

Contributor

Relm-Arrowny commented Jul 23, 2024

I believe to keep track of direction in sim_motor the follow should be:

distance = new_position - old_position

Rather than

distance = abs(new_position - old_position)

Ref
https://github.com/bluesky/ophyd-async/blob/ef1c9426cb20c597a7614686aa01cbf9d43d11ac/src/ophyd_async/sim/demo/sim_motor.py#L46C18-L46C52

coretl mentioned this issue

Fix SimMotor watcher output direction #670

Merged

coretl closed this as completed in #670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment