Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ctl_code const #55

Closed
unlimitedsola opened this issue Dec 6, 2024 · 0 comments · Fixed by #57
Closed

Make ctl_code const #55

unlimitedsola opened this issue Dec 6, 2024 · 0 comments · Fixed by #57

Comments

@unlimitedsola
Copy link
Contributor

unlimitedsola commented Dec 6, 2024

So that it could be used in const context and precomputed at compile time e.g.:

const ACR122_CTL_CODE: DWORD = ctl_code(3500);

It should be a straightforward change and I'm willing to make a PR if needed.

Marking an existing function const shouldn't introduce any breakage as far as I can tell. In my opinion, the chance of this getting "un-constified" is very unlikely. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant