Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid github icon link for "repository" shortcut syntax #109

Closed
hi-ogawa opened this issue Aug 22, 2024 · 2 comments
Closed

Invalid github icon link for "repository" shortcut syntax #109

hi-ogawa opened this issue Aug 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hi-ogawa
Copy link

hi-ogawa commented Aug 22, 2024

I spotted a dead link on https://publint.dev/z3-solver@4.13.0 which uses "repository": "github:Z3Prover/z3". The icon link currently goes to https://github.com/github:Z3Prover/z3.

I'm not sure how common this is but it looks like npm supports a few shortcuts for github:, gitlab: etc... https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository

@bluwy
Copy link
Owner

bluwy commented Aug 22, 2024

Looks like we need to use a more proper parser to fix this. I tried https://github.com/npm/hosted-git-info but the API works awkwardly again where it can't parse from the shorthand, and it's beefy. I don't know if there's other libraries that can do the same out there, or we have to write one ourselves.

@bluwy bluwy added the bug Something isn't working label Aug 22, 2024
@bluwy
Copy link
Owner

bluwy commented Aug 31, 2024

Note to self, there's also https://www.npmjs.com/package/git-url-parse but still kinda beefy

@bluwy bluwy closed this as completed in b79d1fb Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants