-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File existence checks does not work on exports of non-js files #96
Comments
Thanks! I wonder what error do you expect from that currently? It seems the missing published files check, and the file extension check seems to be working fine. About TypeScript support, publint doesn't have much checks for it right now, but it still does check if the file is missing for example. |
Hmm, they don't seem to work on my machine -- whatever I enter into the
Roger that :-) |
Would be great if you can share an example here, otherwise I'm not sure what to fix for this issue. |
Sorry for the delay -- I haven't got as much time as I usually have this week, but I could get you a repro. next week. In my testing, publint wasn't checking what was in the If it helps, the repository in question is https://github.com/freshgum/typedi -- that's where I was able to reproduce the issue :) |
Ah ok I found the issue. On this line: Lines 622 to 623 in 7ba9aa3
If the path is not lintable (which simply means if it's not .js, .cjs, .mjs), it should continue to check if the file exist like: Lines 580 to 588 in 7ba9aa3
But it wasn't. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [publint](https://publint.dev) ([source](https://togithub.com/bluwy/publint/tree/HEAD/pkg)) | [`0.2.7` -> `0.2.8`](https://renovatebot.com/diffs/npm/publint/0.2.7/0.2.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bluwy/publint (publint)</summary> ### [`v0.2.8`](https://togithub.com/bluwy/publint/releases/tag/v0.2.8) [Compare Source](https://togithub.com/bluwy/publint/compare/v0.2.7...v0.2.8) ##### Bug fixes - Fix file existence check for non-js files ([https://github.com/bluwy/publint/issues/96](https://togithub.com/bluwy/publint/issues/96)) **Full Changelog**: bluwy/publint@v0.2.7...v0.2.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/netlify/functions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJqYXZhc2NyaXB0Il19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@changesets/cli](https://togithub.com/changesets/changesets/tree/main#readme) ([source](https://togithub.com/changesets/changesets)) | [`2.27.1` -> `2.27.2`](https://renovatebot.com/diffs/npm/@changesets%2fcli/2.27.1/2.27.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@changesets%2fcli/2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@changesets%2fcli/2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@changesets%2fcli/2.27.1/2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@changesets%2fcli/2.27.1/2.27.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | [`20.12.11` -> `20.12.12`](https://renovatebot.com/diffs/npm/@types%2fnode/20.12.11/20.12.12) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/20.12.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/20.12.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/20.12.11/20.12.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/20.12.11/20.12.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [publint](https://publint.dev) ([source](https://togithub.com/bluwy/publint/tree/HEAD/pkg)) | [`0.2.7` -> `0.2.8`](https://renovatebot.com/diffs/npm/publint/0.2.7/0.2.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>changesets/changesets (@​changesets/cli)</summary> ### [`v2.27.2`](https://togithub.com/changesets/changesets/releases/tag/%40changesets/cli%402.27.2) [Compare Source](https://togithub.com/changesets/changesets/compare/@changesets/cli@2.27.1...@changesets/cli@2.27.2) ##### Patch Changes - [#​1354](https://togithub.com/changesets/changesets/pull/1354) [`69be7dc`](https://togithub.com/changesets/changesets/commit/69be7dc7195011ac6dbd00b24ea923f02adcf69c) Thanks [@​Andarist](https://togithub.com/Andarist)! - Fixed an issue with `changeset status` incorrectly returning an error status in two cases: - for changed ignored packages - for changed private packages when `privatePackage.version` was set to `false` - [#​1351](https://togithub.com/changesets/changesets/pull/1351) [`c6da182`](https://togithub.com/changesets/changesets/commit/c6da182ece2ec40974f15f3efcf9d9ba20cf122b) Thanks [@​TheHolyWaffle](https://togithub.com/TheHolyWaffle)! - Fix an issue with not applying a custom `.prettierrc` configuration with `prettier@>= 3.1.1` - Updated dependencies \[[`c6da182`](https://togithub.com/changesets/changesets/commit/c6da182ece2ec40974f15f3efcf9d9ba20cf122b)]: - [@​changesets/apply-release-plan](https://togithub.com/changesets/apply-release-plan)[@​7](https://togithub.com/7).0.1 - [@​changesets/write](https://togithub.com/changesets/write)[@​0](https://togithub.com/0).3.1 </details> <details> <summary>bluwy/publint (publint)</summary> ### [`v0.2.8`](https://togithub.com/bluwy/publint/releases/tag/v0.2.8) [Compare Source](https://togithub.com/bluwy/publint/compare/v0.2.7...v0.2.8) ##### Bug fixes - Fix file existence check for non-js files ([https://github.com/bluwy/publint/issues/96](https://togithub.com/bluwy/publint/issues/96)) **Full Changelog**: bluwy/publint@v0.2.7...v0.2.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "before 4am on Monday" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tnez/starter-npm-pkg). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNTEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [publint](https://publint.dev) ([source](https://togithub.com/bluwy/publint/tree/HEAD/pkg)) | [`^0.2.7` -> `^0.2.8`](https://renovatebot.com/diffs/npm/publint/0.2.7/0.2.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/publint/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/publint/0.2.7/0.2.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bluwy/publint (publint)</summary> ### [`v0.2.8`](https://togithub.com/bluwy/publint/releases/tag/v0.2.8) [Compare Source](https://togithub.com/bluwy/publint/compare/v0.2.7...v0.2.8) ##### Bug fixes - Fix file existence check for non-js files ([https://github.com/bluwy/publint/issues/96](https://togithub.com/bluwy/publint/issues/96)) **Full Changelog**: bluwy/publint@v0.2.7...v0.2.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/dubzzz/fast-check). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
As of current, publint doesn't seem to support Bun's export field entry.
For example, the following raises no error:
I'd be more than happy to send in a PR if you'd like.
(It's also worth noting that Bun supports TypeScript out-of-the-box, so
"bun": "./src/index.ts"
is possible.)P.S. I'm loving publint so far. It's found two pretty painful issues from the start -- thank you so much!
The text was updated successfully, but these errors were encountered: