Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better link "substanceType" to "ProductType" #61

Open
AFoletti opened this issue Dec 18, 2024 · 0 comments
Open

Better link "substanceType" to "ProductType" #61

AFoletti opened this issue Dec 18, 2024 · 0 comments
Labels
enhancement New feature or request jira Tag to activate JIRA integration v2 A major release Vs. 2

Comments

@AFoletti
Copy link
Member

The standard defines several "*ProductType" via distinct classes, and additionally has an enumType ("productFamilyType") with the list of possible product types.
"substanceType" uses the enumType to inform for which produc type a substance is allowed, but lacks a direct link to a "*ProductType" class.

The whole construct is needlessly complex and at the same time not robust enough to really link a "substanceType" to a product type.

I see two possible solutions:

  1. refactor the distinct "*ProductType" classes into one single, unified "productType" class. This class will contain the product information plus a "family" attribute using the "productFamilyType" enumType to inform about the family of the product. The same list is used in the "substanceType", thus building an n..n relationship between "productType" and "substanceType" thanks to the "productFamilyType"
  2. Keep the distinct "*ProductType" classes but remove the "productFamilyType" enumType completely. The reference in "substanceType" should be done via the ID of an instance of one of the "*ProductType" classes. The product family is derived directly from the class which is instantiated.

If I understand things correctly, option 1) is not really viable for at least one important and well-known BLW application (in development at the time of writing).

Up for discussion. In any case, this is a major change.

See also #42

@AFoletti AFoletti added jira Tag to activate JIRA integration enhancement New feature or request v2 A major release Vs. 2 labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jira Tag to activate JIRA integration v2 A major release Vs. 2
Projects
None yet
Development

No branches or pull requests

1 participant