Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify path for project #1

Closed
wiecznyPoszukiwacz opened this issue Apr 20, 2017 · 6 comments
Closed

Specify path for project #1

wiecznyPoszukiwacz opened this issue Apr 20, 2017 · 6 comments
Labels

Comments

@wiecznyPoszukiwacz
Copy link

For our large project (about 7k files in multiple directories) I create small VS Code projects containing only needed directories. Unfortunatelly, Intelephense scans only those small directories when working with small projects.
It would be great, if I could define directory to scan (different from project directory), so Intelephense would provide definitions and symbols from whole project.

Example:
whole projects lays in c:/projects/system
I'm working with directory c:/projects/system/submodule

It would be great, if I could define

"intelephense.scanDir": "c:/projects/system"

in my c:/projects/system/submodule/.vscode/settings.json

to make Intelephense scan whole large project.

@bmewburn
Copy link
Owner

Thanks for the feedback. I agree that this would be very useful. File finding is currently provided by the vscode workspace api and there is talk of enabling multi folder workspaces. Will investigate further after the outcome of microsoft/vscode#396

@bmewburn
Copy link
Owner

bmewburn commented Nov 5, 2017

In v0.8.0 I've made the extension compatible with the new multi root workspaces. It is experimental at this stage, let me know how it goes.

@Thijzer
Copy link

Thijzer commented Nov 23, 2017

Hi, I don't think this is a a great idea. If I understand this correctly you wish to scope outside root dir. I think the strength of a good intellisense is keep true too the files from the autoloader.

@bmewburn
Copy link
Owner

@Thijzer can you add what the disadvantages are? This just enables users to structure their projects anyway they want. To find symbol definitions the workspace is scanned, any autoload functions or require expressions are not considered.

@Thijzer
Copy link

Thijzer commented Dec 7, 2017

I would consider this unconventional thus I would not let it creep into my code.

It also might find more conflicting namespaces or files, duplications.
I would be better to symlink the core directory into your project vendor dir.

@bmewburn
Copy link
Owner

Closing this as I think multi-root workspaces has solved the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants