Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension crashes on NTFS junctions #461

Closed
marveloo opened this issue May 1, 2019 · 3 comments
Closed

Extension crashes on NTFS junctions #461

marveloo opened this issue May 1, 2019 · 3 comments
Milestone

Comments

@marveloo
Copy link

marveloo commented May 1, 2019

[Info  - 19:05:38] Initialising intelephense 1.0.14
[Info  - 19:05:38] Reading state from c:\Users\User\AppData\Roaming\Code\User\workspaceStorage\246a9677beac5e1d92a141838f688c8e\bmewburn.vscode-intelephense-client\7c2106a5.
[Info  - 19:05:38] Initialised in 28 ms
[Info  - 19:05:38] Indexing started.
[Error - 19:05:38] Error: UNKNOWN: unknown error, lstat 'c:\Users\User\Projects\playground\vendor\bin\phpunit'
(node:6804) UnhandledPromiseRejectionWarning: Error: UNKNOWN: unknown error, lstat 'c:\Users\User\Projects\playground\vendor\bin\phpunit'
(node:6804) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:6804) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:6804) UnhandledPromiseRejectionWarning: Error: UNKNOWN: unknown error, lstat 'c:\Users\User\Projects\playground\vendor\bin\php-parse'
(node:6804) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
[Info  - 19:05:44] Indexing ended. 194 files indexed in 6s.

phpunit and php-parse above are junctions. There were no issues before version 1.0

@marveloo marveloo changed the title Extension crashes on Laravel projects Extension crashes on NTFS junctions May 1, 2019
@marveloo
Copy link
Author

marveloo commented May 1, 2019

As a workaround I converted junctions to symlinks and it seems to have solved my problem, but nevertheless I think Intelephense should be able to ignore files which it cannot read and continue indexing.

@bmewburn
Copy link
Owner

Fixed in fast-glob 3 but needs node 10.10+ . Current vscode ships node 10.2

@bmewburn bmewburn added the bug label May 31, 2019
@bmewburn bmewburn added this to the v1.1 milestone Jun 21, 2019
@bmewburn
Copy link
Owner

1.1 uses fast-glob 3. An additional setting intelephense.runtime has been added to use a node version other than the vscode version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants