Hapless doesn't seem to actually kill the background task

[nathan-fiscaletti]

Step 1: Create a background task using hapless.

Step 2: Hapless shows it as running.

Step 3: Checking the processes with ps shows three distinct processes for the task. The pid reported by hapless seems to be the second in the list from ps.

When I attempt to kill the task all but the last of the processes from ps seem to be killed, which leaves the task running even though hapless reports that it isn't running.

[bmwant]

Hey @nathan-fiscaletti, could you provide additional information:

1. hapless version: hap --version
2. your OS
3. content of the script if possible. If not I would like to know whether it spawns/forks/multiprocess etc within the script

[bmwant]

Only two processes should be created:
one main for the hapless itself
second one for the process you actually need to execute
You can check your parent pid also by invoking hap status -v 1 or using something like pstree to see whether you third process is related in any way to previous two

[bmwant]

ok, I found the issue and it is related to the shell=True parameter and extra process being created for the shell itself (tried on Ubuntu 20.04). I have created a fix to kill child process as well and will release new version soon.

In a future release I do also plan to skip shell spawning altogether and just provide current environment directly to the subprocess.

[bmwant]

In a meanwhile you can test the fix by yourself by installing latest development branch

$ pip install git+https://github.com/bmwant/hapless.git