Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start node with the default BSC genesis block instead of ETH #2013

Closed
weiihann opened this issue Nov 28, 2023 · 0 comments
Closed

start node with the default BSC genesis block instead of ETH #2013

weiihann opened this issue Nov 28, 2023 · 0 comments
Assignees

Comments

@weiihann
Copy link
Contributor

weiihann commented Nov 28, 2023

Rationale

Whenever a user starts a node, this is what they see:

INFO [11-28|17:14:16.845] Starting Geth on Ethereum mainnet...
...

It's confusing for node operators to see that Geth is running on Ethereum mainnet, even though it's running on BSC mainnet. This is primarily because the --networkid isn't set. In fact, it's not necessary to set it because usually we would parse a config.toml file. However, it'll still be great if we change the default wordings on the logs so it's a better user experience for BSC node operators.

When a user runs geth init from scratch (i.e. sync from genesis block), the default Ethereum genesis block is used. Instead of that, can we use the BSC genesis block as the default block? Or another idea is once the node detects that ETH genesis block is being used, immediately stop the node and let the user know that he/she should do geth init genesis.json first.

Implementation

  • Change Ethereum mainnet to BSC mainnet
  • Two options:
    • Include the default BSC genesis block data
    • Execute log.Crit if ETH genesis block is being used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant