Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable pending block access without --mine parameter #997

Closed
billyadelphia opened this issue Jul 16, 2022 · 6 comments
Closed

Re-enable pending block access without --mine parameter #997

billyadelphia opened this issue Jul 16, 2022 · 6 comments

Comments

@billyadelphia
Copy link

Based on my question #778 and this issue #358
Even with --mine parameter, I still can't access pending block somehow.

Rationale

Why should this feature exist?
Because it's enabled by default on any other EVM blockchain, a lot of us needed this.

Implementation

Do you have ideas regarding the implementation of this feature?
I have tried, but gave up. It doesn't have to enabled by default, like adding new param like --enable-pending-block or else

Are you willing to implement this feature?
No

@yutianwu
Copy link
Contributor

There was a performance issue related to the --mine flag, so we disabled it. There is no plan to add it back recently.

@billyadelphia
Copy link
Author

@yutianwu if you want to enable it, which line of code would you change ?

I have tried to change the PendingBlock function on miner.go file based on the original geth (for ethereum), compile it myself, but it just throw some weird error.

@yutianwu
Copy link
Contributor

We disabled this feature in #358, you can refer to this.

@aitimate
Copy link

@yutianwu if you want to enable it, which line of code would you change ?

I have tried to change the PendingBlock function on miner.go file based on the original geth (for ethereum), compile it myself, but it just throw some weird error.

@yutianwu if you want to enable it, which line of code would you change ?

I have tried to change the PendingBlock function on miner.go file based on the original geth (for ethereum), compile it myself, but it just throw some weird error.

How do you solve it now?

@aitimate
Copy link

We disabled this feature in #358, you can refer to this.

How to config to re-enable pending function?

@ofarukcaki
Copy link

This is the reason I started learning go and my go knowledge is limited, any help regarding to re-enable this feature is appreciated. Currently I'm checking go-ethereum and the #358 together but no luck so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants