Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context in functions to make debugging easier and Add GetBuildFromQueueID() function #220

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

figo
Copy link
Collaborator

@figo figo commented Dec 16, 2020

  1. Add context in functions to make debugging easier

    if "debug" been set in context, will dump response data including body.
    we can pass logger in context in the future

  2. Add GetBuildFromQueueID() function

    a) This function going to return the build object base on task/queue id.
    Jenkins will queue a task for a few second and assign the build number.

    b) Update REAME file for use case of triggering a job and get the result of the build.
    Update README with context paramete

    Signed-off-by: Hui Luo luoh@vmware.com

if "debug" been set in context, will dump response data including body.
we can pass logger in context in the future

Signed-off-by: Hui Luo <luoh@vmware.com>
1) This function going to return the build object base on task/queue id.
Jenkins will queue a task for a few second and assign the build number.

2) Update REAME file for use case of triggering a job and get the result of the build.
Update README with context parameter

Signed-off-by: Hui Luo <luoh@vmware.com>
artifact.go Outdated Show resolved Hide resolved
build.go Outdated Show resolved Hide resolved
Copy link

@ZihanJiang96 ZihanJiang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 minor things. 👍

Signed-off-by: Hui Luo <luoh@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants