Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the null/empty string checking in MyDocument #50

Open
bngarren opened this issue Feb 11, 2022 · 0 comments
Open

Refactor the null/empty string checking in MyDocument #50

bngarren opened this issue Feb 11, 2022 · 0 comments
Labels
refactoring/code quality Optimization, refactoring - not bugs, styling, or feature

Comments

@bngarren
Copy link
Owner

Hotfix #49 fixes a critical react-pdf renderer problem. Apparently, the and/or components don't like to be empty. It seems to mess with their style calculations if align or height can't be figured out.

Need to consider a cleaner way of doing this at the top, prior to the return

Originally posted by @bngarren in #49 (comment)
@bngarren bngarren added the refactoring/code quality Optimization, refactoring - not bugs, styling, or feature label Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring/code quality Optimization, refactoring - not bugs, styling, or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bngarren