Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't compile on Node.js v12.0.0-pre #198

Closed
BridgeAR opened this issue Mar 29, 2019 · 1 comment
Closed

Can't compile on Node.js v12.0.0-pre #198

BridgeAR opened this issue Mar 29, 2019 · 1 comment

Comments

@BridgeAR
Copy link
Contributor

Due to the recent V8 update (7.4) it's not possible to build iconv anymore.

See https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1781/nodes=debian8-64/testReport/junit/(root)/citgm/iconv_v2_3_3/
@targos targos mentioned this issue Mar 29, 2019
Closed
@bnoordhuis
Copy link
Owner

This will be fixed in v2.3.4 which I'll release as soon as I get to a computer where I can npm publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bnoordhuis @BridgeAR