Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octal escape sequence in string doesn't work #1078

Closed
jevancc opened this issue Jan 18, 2021 · 0 comments · Fixed by #1079
Closed

Octal escape sequence in string doesn't work #1078

jevancc opened this issue Jan 18, 2021 · 0 comments · Fixed by #1079
Assignees
@jevancc
Labels
bug Something isn't working lexer Issues surrounding the lexer
Milestone
v0.12.0

Comments

@jevancc
Copy link
Contributor

jevancc commented Jan 18, 2021

Describe the bug
The octal escape sequence in string literal (non-strict mode) doesn't work properly.

To Reproduce

"\43"; // should equal to "#"
"\101"; // should equal to "A"

Additional context
None
@jevancc jevancc added the bug Something isn't working label Jan 18, 2021
@jevancc jevancc mentioned this issue Jan 18, 2021
Merged
@tofpie tofpie added the lexer Issues surrounding the lexer label Jan 18, 2021
@Razican Razican added this to the v0.12.0 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jevancc jevancc

Labels
bug Something isn't working lexer Issues surrounding the lexer
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging a pull request may close this issue.

Fix lexing escapes in string literal and minor refactor jevancc/boa
3 participants
@Razican @jevancc @tofpie