String.replace(regexp|substr, newSubstr|function)

[jasonwilliams]

replace function would need to be added to the string object here:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/string.rs

It would be very similar to:
https://github.com/jasonwilliams/boa/blob/master/src/lib/js/regexp.rs#L212-L251

Spec:
https://tc39.es/ecma262/#sec-string.prototype.replace

Notes:
https://github.com/jasonwilliams/boa/blob/master/docs/debugging.md

[louiidev]

Hey mate, can I have a go of this?

[thiagoarrais]

@louisgjohnson: still working on this? I would like to help with it.

[cemremengu]

@jasonwilliams I think this is already added (as I understand from the discussions)

[RageKnify]

@jasonwilliams you implemented this in #217, but as I noted in #629 , there is a bug with the current implementation:
Copied from Chrome:

> let str = 'boa';
> str.replace(/.*/, "??$&??")
"??boa??"
> str.replace(".*", "??$&??")
"boa"

While on boa both would return "??boa??" because the string ".*" is converted to a RegEx pattern.

Looking at the spec: https://tc39.es/ecma262/#sec-string.prototype.replace
I believe on point 2 if searchValue is a RegExp object it should give RegExp.prototype [ @@replace ] as replacer. Which would then be invoked. @@replace exists, but RegExp.prototype [ @@replace ] isn't implemented, I think the code in String.replace is an aproximation of it.

After #629 gets merged I'd like to look into implementing RegExp.prototype[ @@replace ] and making String.replace spec compliant.

[jedel1043]

Closing, as the bug that blocked this is solved. If we overlooked something we can open another issue with the specific problem.