Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement global globalThis property #120

Closed
jasonwilliams opened this issue Sep 27, 2019 · 4 comments · Fixed by #495
Closed

Implement global globalThis property #120

jasonwilliams opened this issue Sep 27, 2019 · 4 comments · Fixed by #495
Assignees
@zanayr
Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Milestone
v0.9.0

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Sep 27, 2019 •
edited by HalidOdat
Loading

ECMASCript feature

We can add this by adding a new module like NaN https://github.com/boa-dev/boa/tree/master/boa/src/builtins/nan and then adding it to the builtin init function in builtins/mod.rs the value it should contain should be global.clone() (this is the value passed to init function)

More information
- ECMAScript reference
- MDN
@jasonwilliams jasonwilliams added this to the Boa Shell milestone Sep 27, 2019
@jasonwilliams jasonwilliams self-assigned this Oct 17, 2019
@Razican Razican added the enhancement New feature or request label Apr 3, 2020
@jasonwilliams jasonwilliams removed this from the Boa Shell milestone Apr 12, 2020
@jasonwilliams jasonwilliams added E-Easy Easy good first issue Good for newcomers labels May 14, 2020
@jasonwilliams jasonwilliams added this to the v0.9.0 milestone May 14, 2020
@jasonwilliams jasonwilliams removed the E-Easy Easy label May 14, 2020
@jasonwilliams jasonwilliams changed the title globalThis object which points to the current global object globalThis May 14, 2020
@jasonwilliams jasonwilliams removed their assignment May 24, 2020
@HalidOdat HalidOdat changed the title globalThis Implement global globalThis property Jun 11, 2020
@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics E-Easy Easy labels Jun 11, 2020
@zanayr
Copy link
Contributor

zanayr commented Jun 12, 2020

Hello @jasonwilliams, can I take this? :)

@HalidOdat
Copy link
Member

can I take this? :)

Sure. go for it! If you have any questions or need some assistance tell us :)

@zanayr zanayr mentioned this issue Jun 15, 2020
Merged
@zanayr
Copy link
Contributor

zanayr commented Jun 15, 2020

Hello I have issued a PR #495... I'm not sure if I did it correctly, I am getting several failed checks.. I assume I messed up the testing somehow, any tips on how to fix this? Best,

@zanayr
Copy link
Contributor

zanayr commented Jun 15, 2020

Coool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanayr zanayr

Labels
builtins PRs and Issues related to builtins/intrinsics E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Added globalThis property
4 participants
@Razican @jasonwilliams @HalidOdat @zanayr