Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the MethodDefinition parser #1527

Closed
raskad opened this issue Aug 28, 2021 · 1 comment
Closed

Refactor the MethodDefinition parser #1527

raskad opened this issue Aug 28, 2021 · 1 comment
Labels
parser Issues surrounding the parser technical debt
Milestone

Comments

@raskad
Copy link
Member

raskad commented Aug 28, 2021

The parser for MethodDefinition currently expects an identifier in it's new function. This is either the get or set keyword or the name of the method. The parse method then parses everything after this first identifier.
This is confusing, because the spec specifies that the first identifier belongs to the MethodDefinition.

We should either refactor the MethodDefinition parser to adhere to the spec or rename it to avoid confusion.

Relevant discussion: #1526 (comment)

@raskad raskad added technical debt parser Issues surrounding the parser labels Aug 28, 2021
@jedel1043
Copy link
Member

Fixed by #1575

@jedel1043 jedel1043 added this to the v0.14.0 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser Issues surrounding the parser technical debt
Projects
None yet
Development

No branches or pull requests

2 participants