Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new verbosity level to boa_tester to reduce the output in -vv mode #1643

Closed
Razican opened this issue Oct 7, 2021 · 7 comments
Closed
Assignees
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Milestone

Comments

@Razican
Copy link
Member

Razican commented Oct 7, 2021

Currently we have 3 vervosity modes in the boa_tester:

  • 0: when no -v flag is provided, we just show one colored dot per test, indicating if it passed or not, and the final results
  • 1: when -v is provided, we show information on each test suite that ran, along with some extra information messages
  • 2: when -vv is provided, it will give information on each test being run, along with information on the output in case it failed.

The issue is that there is no way of knowing the failing tests without getting the full output of the test, which can make the output difficult to read if you are only trying to find the failing test.

The idea behind this enhancement proposal is to add a new verbosity level, -vvv, that would include the output of failing tests that is now shown in -vv.

This is controlled in here. The idea is to change that verbosity comparison to > 2, so that it will only be shown when -vvv (or more) is provided.

@Razican Razican added enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com E-Easy Easy labels Oct 7, 2021
@Razican Razican added this to the v0.14.0 milestone Oct 7, 2021
@praveenbakkal
Copy link
Contributor

@Razican can you please assign this to me?

@Razican
Copy link
Member Author

Razican commented Oct 7, 2021

@Razican can you please assign this to me?

Done! :)

@praveenbakkal
Copy link
Contributor

Thank you. Will work on it and raise the PR.

@chebro
Copy link

chebro commented Oct 11, 2021

@Razican is this up for grabs? i'd like to work on it if it's not being actively worked on!

@praveenbakkal
Copy link
Contributor

@Razican @chebro I am working on it, will be raising the PR today

@chebro
Copy link

chebro commented Oct 21, 2021

sorry if i'm being pendantic, but i'd really love to have this feature implemented asap as it helps in identifying exactly which tests are failing, i'd like to work on this if it's still open 😅

@praveenbakkal
Copy link
Contributor

@chebro I have raised the PR #1680 already, will work on the additional changes if required.

@Razican Razican closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Development

No branches or pull requests

3 participants