-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divide the byte compiler #1808
Comments
@Razican can I take a deal with the issue? |
@justunkn sure, assigned |
@justunkn do you have any news on this? |
Does this issue still need to be worked on? It appears that #2343 fixes it, I would be willing to attempt some work on it otherwise though. |
It doesn't fix it though. The byte compiler and the VM are in separate modules |
Ah okay, in that case I'll see if I can do anything wrt fixing up the byte compiler organization. I'm assuming it makes the most sense to extract each of the longer match arm paths into separate files/functions? |
Yep! Thank you! |
Quick question: Within the bytecompiler module, theres some code that feels confusing to read because of the ambiguity about which |
AstLiteral sounds good! |
I think this happens in multiple places, where we have the parser and the AST node with the same time. Maybe we should have a review on all these names. |
Currently, the byte compiler is written in a file with almost 2,000 lines. Each execution path should be divided in submodules, in order to reduce the size of the file and to make it more maintainable.
The text was updated successfully, but these errors were encountered: