Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing tc39/test262 submodule and download lazily #3095

Closed
mattsse opened this issue Jul 2, 2023 · 2 comments · Fixed by #3214
Closed

Consider removing tc39/test262 submodule and download lazily #3095

mattsse opened this issue Jul 2, 2023 · 2 comments · Fixed by #3214
Assignees

Comments

@mattsse
Copy link
Contributor

mattsse commented Jul 2, 2023

Due to how cargo handles submodules (or rather doesn't): rust-lang/cargo#4247

a fresh cargo build with boa as git dependency boa { git = "..."} will download all submodules and it takes some time to download https://github.com/tc39/test262

Perhaps it's possible to download the repo lazily instead, for example:

dtolnay/syn#183

@gakonst
Copy link

gakonst commented Aug 14, 2023

hi @HalidOdat - just flagging again...thank you for all the work for this crate. also I think doing a release would also fix this?

@HalidOdat HalidOdat self-assigned this Aug 14, 2023
@HalidOdat
Copy link
Member

I think doing a release would also fix this?

This would be a temporary fix though, I'll create a PR with a proper fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants