Cancel/Interrupt active evaluation

[mattsse]

feature
I would like to be able to cancel an evaluation (or JsValue::call) after a certain timeout.
Perhaps this is already possible, but I wasn't able to find it.

boja for example has interrupts:

https://github.com/dop251/goja/blob/b396bb4c349df65109dea3df00fb60f6a044950d/runtime.go#L1474C9-L1482

my motivation for this is to have the option to terminate a (malicious) evaluation for example while(1) {}

Example code
Give a code example that should work after the implementation of this feature.

[jedel1043]

There isn't a hook to do this at the moment, but we have plans to support this. The simplest API I can think of is a way to set a flag for the Context from another thread that marks it as interrupted. Would that be enough to support your use case?

[mattsse]

cool.

The simplest API I can think of is a way to set a flag for the Context from another thread that marks it as interrupted

yeah, this is exactly what I'm looking for, like Interrupt(Arc<AtomicBool>) or equivalent.

[jedel1043]

yeah, this is exactly what I'm looking for, like Interrupt(Arc<AtomicBool>) or equivalent.

Alright, I'll put this on our backlog then.

[felipefdl]

It's difficult to use Boa for running untrusted third-party code without a way to interrupt eval.

I appreciate the simplicity and effectiveness of rquickjs's set_interrupt_handler method for handling this issue. It's a great solution for many use cases.

Here's an example showing how a timeout could be implemented using set_interrupt_handler:

let timestamp_now = std::time::SystemTime::now();

rt.set_interrupt_handler(Some(Box::new(move || {
  if let Ok(elapsed) = timestamp_now.elapsed() {
    if elapsed.as_millis() > 1000 {
      return true;
    }
  }

  false
})));