-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ECMAScript syntax for regular expressions #478
Comments
Hi! |
One option would be to implement those methods in regress. What would we need? |
Specifically I've been looking into regress's API and it actually does have a lot of the methods just labelled differently or structured differently, currently working on trying to refactor everything involving regex into regress atm. |
Have been working on refactoring regexp and string, and managed to finish string, however, am a little stuck on the regexp regex implementations, especially with working with the capture groups that regress has got strange methods, if anyone is able to help, would be much appreciated. |
Hey, do you have the code you are working on? Maybe create a draft PR so that we can give you feedback :) |
Current situation
Currently, we use regular expressions from the
regex
crate. They are extremely fast, but they don't support the full ECMAScript syntax like backreferences or lookaround assertions.Solution
We should use a library that does support all this syntax. A nice library that was just released and seems to support this is
regress
.We should remove our dependency on
regex
and useregress
, and see how the performance gets affected.The text was updated successfully, but these errors were encountered: