Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring Clippy warnings down to 0 #61

Closed
jasonwilliams opened this issue Jul 7, 2019 · 3 comments
Closed

Bring Clippy warnings down to 0 #61

jasonwilliams opened this issue Jul 7, 2019 · 3 comments
Assignees
@Korpen

Comments

@jasonwilliams
Copy link
Member

jasonwilliams commented Jul 7, 2019 •
edited
Loading

There's some low hanging fruit in this one, we've now enabled Clippy. Clippy is the Rust linter

This means there's some linting issues that will need fixing. You can see the warnings from each build for e.g here: https://travis-ci.com/jasonwilliams/boa/jobs/213821772

  • Install Clippy (link above)
  • Checkout the project as normal, and run cargo clippy in the project.
@jasonwilliams jasonwilliams added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 7, 2019
@jasonwilliams jasonwilliams mentioned this issue Jul 9, 2019
Merged
@Korpen
Copy link
Contributor

Korpen commented Sep 28, 2019

I'd like to work on this if it's still needed.

@jasonwilliams
Copy link
Member Author

@Korpen sure, assigned

@jasonwilliams
Copy link
Member Author

Fixed, thanks @Korpen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Korpen Korpen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasonwilliams @Korpen