Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression: infinite loop with "receive event gameHeight" #132

Open
RobertBolender opened this issue May 20, 2021 · 2 comments

Comments

@RobertBolender
Copy link
Contributor

I'm seeing constant console.logs for receive event gameHeight in my browser, and also noticed that the game has massively drained my iPhone battery while playing the game on mobile Safari. I believe this to be a recent regression, had not been happening before.

@coyotte508
Copy link
Member

The gameHeight is more on the boardgamers-mono side: https://github.com/boardgamers/boardgamers-mono/blob/master/api-node/app/resources.ts#L128

It shouldn't be causing issues, if the emitted values are always the same. And I'm not sure it's needed anymore with the new version.

The performance issue should come from somewhere else; I'm not sure where to start.

@RobertBolender
Copy link
Contributor Author

The memory heap size may or may not also be relevant, with a long-running tab but no one making any moves:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants