Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE conditional comments not taken into account #22

Open
tomlankhorst opened this issue Nov 26, 2017 · 1 comment
Open

IE conditional comments not taken into account #22

tomlankhorst opened this issue Nov 26, 2017 · 1 comment

Comments

@tomlankhorst
Copy link

Magento adds some compatibility styles with additional parameters for older IE versions. I.e. in app/design/adminhtml/default/default/layout/main.xml on line 86 and further:

<action method="addItem"><type>skin_css</type><name>iestyles.css</name><params/><if>lt IE 8</if></action>
<action method="addItem"><type>skin_css</type><name>below_ie7.css</name><params/><if>lt IE 7</if></action>
<action method="addItem"><type>skin_css</type><name>ie7.css</name><params/><if>IE 7</if></action>

When these 'items' are put at the end of the HTML output, their IE conditional comments are not respected. This leads to parsing of IE styles in non-IE browsers.

@bobbyshaw
Copy link
Owner

Hi @tomlankhorst. Thanks for your report. I notice that the path you mention is for admin. I don't think I made this module functional in the admin area, is this something that you have implemented?

I do remember working on adding compatibility with IE comments on the frontend though. There is at least a portion of the regex set out for it: https://github.com/bobbyshaw/magento-footer-js/blob/master/src/app/code/community/Meanbee/Footerjs/Helper/Data.php#L6

Do you have the same problem on the frontend? If so, can you share your magento version please?

Another route to a solution: I think these IE browsers are old enough that you won't need to be supporting them any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants