Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently I've been seeing Warnings #14

Closed
zzarbi opened this issue May 30, 2020 · 5 comments
Closed

Recently I've been seeing Warnings #14

zzarbi opened this issue May 30, 2020 · 5 comments

Comments

@zzarbi
Copy link

zzarbi commented May 30, 2020

Screen Shot 2020-05-30 at 3 10 07 PM

^ You can ignore the red error one, that's mine. Here's how I use deployment:
      - name: Flag Deployment in Github
        uses: bobheadxi/deployments@master
        id: deployment
        with:
          step: start
          token: ${{ secrets.GITHUB_TOKEN }}
          env: staging

and

      - name: Close deployment
        uses: bobheadxi/deployments@master
        with:
          step: finish
          status: success
          token: ${{ secrets.GITHUB_TOKEN }}
          deployment_id: ${{ needs.deploy_staging.outputs.deployment_id }}
@bobheadxi
Copy link
Owner

Thanks for pointing this out @zzarbi - it looks like GitHub has started making use of defined parameters in action.yml...

I'll update this soon to define all the optional params in the file, which should make the issue go away - I'll ping back on this ticket when I get to that!

(aside: I never defined everything in action.yml because it felt kind of pointless - you define parameters and docs, but they don't get rendered anywhere, which means I have to write it all out again in the README, but I digress 🙃 )

@munjalpatel
Copy link

@bobheadxi any updates here? I am also running into this issue.

@maslick
Copy link

maslick commented Nov 7, 2020

I'm seeing this:

Warning: Unexpected input(s) 'env', valid inputs are ['token', 'step', 'auto_inactive', 'logs', 'desc', 'ref']
Warning: Unexpected input(s) 'status', 'env_url', 'deployment_id', valid inputs are ['token', 'step', 'auto_inactive', 'logs', 'desc', 'ref']
- name: Start deployment
  uses: bobheadxi/deployments@v0.4.2
  id: deployment
  with:
    step: start
    token: ${{ secrets.GITHUB_TOKEN }}
    env: prod
    ref: ${{ github.head_ref }}
- name: Update deployment status
  uses: bobheadxi/deployments@v0.4.2
  if: always()
  with:
    step: finish
    token: ${{ secrets.GITHUB_TOKEN }}
    status: ${{ job.status }}
    env_url: https://${{ env.domain }}/
    deployment_id: ${{ steps.deployment.outputs.deployment_id }}

Any updates? :)
Thanks!

@bobheadxi
Copy link
Owner

bobheadxi commented Nov 26, 2020

v0.4.3 contains some additional parameter definitions from #23 (thanks @louy!)

There might be some missing still, but note that while GitHub shows a warning it does not actually affect any functionality

@bobheadxi
Copy link
Owner

bobheadxi commented Feb 22, 2022

As of bobheadxi/deployments@v1, all action parameter definitions should be up to date. Thank you for chiming in everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants