Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol-based loading of templates does not work #283

Open
oschettler opened this issue Feb 4, 2016 · 0 comments
Open

Protocol-based loading of templates does not work #283

oschettler opened this issue Feb 4, 2016 · 0 comments

Comments

@oschettler
Copy link
Contributor

When using a protocol other than "file://" to load templates with Mustache_Loader_FilesystemLoader, I get an error FilesystemLoader baseDir must be a directory.

I have provided a pull request to fix the code and test.

I've fixed the code to check for existing directory and file only when there is no protocol.
To make the test Mustache_Test_Loader_FilesystemLoaderTest.testConstructorWithProtocol actually fail for these checks, I have implemented a minimal protocol "test://".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant