Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bochs usb debug message improvement #347

Open
CorruptedByCPU opened this issue Sep 8, 2024 · 0 comments
Open

bochs usb debug message improvement #347

CorruptedByCPU opened this issue Sep 8, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@CorruptedByCPU
Copy link

Hey @fysnet !

I have a little propose of Bochs USB debug message improvement.

Somehow for me (maybe others too) this is a little inconvenient to read [b]packet[/b] content before its [b]description[/b].

What do You think about below example?

Original:

00211605837d[USBHID] Reset
00217856000d[USBHID] packet hexdump (8 bytes)
00217856000d[USBHID] 80 06 00 01 00 00 08 00
00217856000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device
00217856000d[USBHID] packet hexdump (8 bytes)
00217856000d[USBHID] 12 01 01 01 00 00 00 08
00220416000d[USBHID] packet hexdump (8 bytes)
00220416000d[USBHID] 00 05 01 00 00 00 00 00
00220416000d[USBHID] USB_REQ_SET_ADDRESS:
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] 80 06 00 01 00 00 12 00
00220480000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] 12 01 01 01 00 00 00 08
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] B4 04 01 01 01 00 01 02
00220480000d[USBHID] packet hexdump (2 bytes)
00220480000d[USBHID] 03 01
00220544000d[USBHID] packet hexdump (8 bytes)
00220544000d[USBHID] 80 06 00 02 00 00 09 00
00220544000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config
00220544000d[USBHID] packet hexdump (8 bytes)
00220544000d[USBHID] 09 02 22 00 01 01 04 A0
00220544000d[USBHID] packet hexdump (1 bytes)
00220544000d[USBHID] 32
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 80 06 00 02 00 00 22 00
00220608000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 09 02 22 00 01 01 04 A0
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 32 09 04 00 00 01 03 01
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 01 05 09 21 01 01 00 01
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 22 40 00 07 05 81 03 08
00220608000d[USBHID] packet hexdump (2 bytes)
00220608000d[USBHID] 00 0A
00220672000d[USBHID] packet hexdump (8 bytes)
00220672000d[USBHID] 00 09 01 00 00 00 00 00
00220672000d[USBHID] USB_REQ_SET_CONFIGURATION: value=1
00220736000d[USBHID] packet hexdump (8 bytes)
00220736000d[USBHID] 21 0A 00 08 00 00 00 00
00220736000d[USBHID] HID: SET_IDLE:

Reorganized:

00211605837d[USBHID] Reset
00217856000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device (Request)
00217856000d[USBHID] packet hexdump (8 bytes)
00217856000d[USBHID] 80 06 00 01 00 00 08 00
00217856000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device (Answer)
00217856000d[USBHID] packet hexdump (8 bytes)
00217856000d[USBHID] 12 01 01 01 00 00 00 08
00220416000d[USBHID] USB_REQ_SET_ADDRESS: (Request, no Answer required)
00220416000d[USBHID] packet hexdump (8 bytes)
00220416000d[USBHID] 00 05 01 00 00 00 00 00
00220480000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device (Requst)
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] 80 06 00 01 00 00 12 00
00220480000d[USBHID] USB_REQ_GET_DESCRIPTOR: Device (Answer)
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] 12 01 01 01 00 00 00 08
00220480000d[USBHID] packet hexdump (8 bytes)
00220480000d[USBHID] B4 04 01 01 01 00 01 02
00220480000d[USBHID] packet hexdump (2 bytes)
00220480000d[USBHID] 03 01
00220544000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config (Request)
00220544000d[USBHID] packet hexdump (8 bytes)
00220544000d[USBHID] 80 06 00 02 00 00 09 00
00220544000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config (Answer)
00220544000d[USBHID] packet hexdump (8 bytes)
00220544000d[USBHID] 09 02 22 00 01 01 04 A0
00220544000d[USBHID] packet hexdump (1 bytes)
00220544000d[USBHID] 32
00220608000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config (Request)
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 80 06 00 02 00 00 22 00
00220608000d[USBHID] USB_REQ_GET_DESCRIPTOR: Config (Answer)
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 09 02 22 00 01 01 04 A0
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 32 09 04 00 00 01 03 01
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 01 05 09 21 01 01 00 01
00220608000d[USBHID] packet hexdump (8 bytes)
00220608000d[USBHID] 22 40 00 07 05 81 03 08
00220608000d[USBHID] packet hexdump (2 bytes)
00220608000d[USBHID] 00 0A
00220672000d[USBHID] USB_REQ_SET_CONFIGURATION: value=1 (Request, no Answer required)
00220672000d[USBHID] packet hexdump (8 bytes)
00220672000d[USBHID] 00 09 01 00 00 00 00 00
00220736000d[USBHID] HID: SET_IDLE: (Request)
00220736000d[USBHID] packet hexdump (8 bytes)
00220736000d[USBHID] 21 0A 00 08 00 00 00 00

Regards, Andrzej Adamczyk
CorruptedByCPU

@stlintel stlintel added the enhancement New feature or request label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants