Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesis type -> thesis_degree_level #128

Open
mrdsaunders opened this issue Nov 18, 2019 · 7 comments
Open

Thesis type -> thesis_degree_level #128

mrdsaunders opened this issue Nov 18, 2019 · 7 comments

Comments

@mrdsaunders
Copy link
Collaborator

mrdsaunders commented Nov 18, 2019

See @tomwrobel's comment of 2019-11-18 10:42, this contains instructions for resolving this ticket post go-live.

Hi

The maping document has:

<symplectic_field name="thesis-type"><ora_field>thesis_degree_level</ora_field></symplectic_field>

However Toby thinks the forms only have <uketdterms:qualificationname>field:thesis_degree_name</uketdterms:qualificationname> (which is not mapped) and not <uketdterms:qualificationlevel>field:thesis_degree_level</uketdterms:qualificationlevel>.

Does the mapping or the forms need updating?

@tomwrobel
Copy link
Collaborator

tomwrobel commented Nov 18, 2019

Thesis degree name should be mapped as well if it is available

field:thesis_degree_name is the title of the degree, e.g. 'PhD' 'DPhil', 'MA'
field:thesis_degree_level is the type of degree, e.g. 'masters', 'doctoral' etc. (the mappings are not always simple, BCh is not an undergraduate degree, for example)

field:thesis_degree_level doesn't appear in the forms, as it is configured via a mapping with degree name behind the scenes. It should still be available in the crosswalks.

What to do

EITHER

  • IF symplectic-field:thesis-degree-type has a typical value of 'MSc', 'DPhil', etc., THEN it should map to field:thesis_degree_name and we'll need to do some mapping at our end for degree level.
  • ELSE IF symplectic-field:thesis-degree-type has a typical value of 'Masters', 'Doctoral', THEN it should map to field:thesis_degree_level as now, but we will need a list of all possible values in order to crosswalk them to and from EThOS degree levels. These will need to be added to the crosswalks.

AND

  • regardless of the above, if there is a separate field which equates to thesis_degree_level OR thesis_degree_name which is not listed in the crosswalks, then we need to crosswalk this field.

@mrdsaunders: two questions:

  1. What is the normal value of symplectic-field:thesis-type?
  2. is there another field here we should be crosswalking?

@tomwrobel
Copy link
Collaborator

@mrdsaunders I think, however, that this ticket should be moved to post release development: theses won't be submitted for some time

@jjpartridge and I have discussed this, and we agrees. Can we briefly clarify which values Symplectic is sending, and which values it holds, and then park this ticket for later?

@mrdsaunders
Copy link
Collaborator Author

SE has only 'Thesis type'. Values are:

  • PhD Thesis
  • Master's Thesis
  • Undergraduate Dissertation

@mrdsaunders
Copy link
Collaborator Author

It currently sends this via Crosswalk to thesis_degree_level

@tomwrobel
Copy link
Collaborator

tomwrobel commented Nov 18, 2019

Then thesis_degree_level is correct

In that case, it can't be fixed now, and doesn't have to be. I've ammended the top of this ticket to point to the checklist below:

MAPPINGS FOR FUTURE USE

PhD Thesis: doctoral
Master's Thesis: masters
Undergraduate Dissertation: undergraduate

In addition, in order to close this ticket we would need to resolve what we do in the forms if no thesis_degree_name is supplied.

TO DO:

@mrdsaunders
Copy link
Collaborator Author

Have amended crosswalk

@tomwrobel
Copy link
Collaborator

@mrdsaunders ty! I'll get on to the ORA issue (although perhaps not for a little while): https://trello.com/c/enHtH7N4/44-ora4-phd-degree-name-is-not-automatically-assigned-from-degree-level-in-oxris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment