Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit is sending unwanted article number number data for Working Paper #152

Open
mrdsaunders opened this issue Dec 6, 2019 · 3 comments

Comments

@mrdsaunders
Copy link
Collaborator

For SE field 'Paper number' there is an issue with the crosswalks in that for type Working Paper as well as sending the intended:

<mods:identifier type="paper_number">paper number test 2</mods:identifier>

it is also sending an unwanted:

<mods:relatedItem type="host">
    <mods:part>
        <mods:detail type="article">
                    <mods:number>paper number test 2</mods:number>
        </mods:detail>
    </mods:part>

It is a surprisingly difficult thing to correct. In the short term, is this a problem? Or since mods:number is not in the data model for Working Paper will it float about in the ether not causing a problem?

@tomwrobel
Copy link
Collaborator

@mrdsaunders that will cause a problem, I'm afraid. It will leave a zombie value kicking around that probably won't re-manifest until publication (when article number will appear in the bibliographic info). @jjpartridge can decide how severe this is, if at all

@tomwrobel tomwrobel added this to the Complete crosswalk milestone Dec 6, 2019
@jjpartridge
Copy link
Collaborator

@thomas-wrobel why would this appear as 'article number' is this because of the data model difference between ORA4 and public?

In the short term it seems that it would be acceptable enough. The fields aren't too dissimilar!

@tomwrobel
Copy link
Collaborator

@jjpartridge it would appear as article number because the value is being set. It wouldn't be visible in the forms, but there's a good chance that the publication process (which just dumbly pumps set values into Solr) doesn't know not to set it.

I can't confirm that this would be the bug, but you're right, it isn't the end of the world. I'm moving this to post-release development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants