Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softmax in the evaluation stage #7

Open
saeedizadi opened this issue Jul 18, 2017 · 1 comment
Open

Softmax in the evaluation stage #7

saeedizadi opened this issue Jul 18, 2017 · 1 comment

Comments

@saeedizadi
Copy link

Hi,

I've found that you are explicitly applying log_softmax in your criterion.py file. Isn't is necessary to explicitly apply the softmax function on the output of the network in the evaluation stage? that is, before getting the maximum index for each class?

Thanks

@bodokaiser
Copy link
Owner

Hey,

yes, I think you are right. Could you test what happens if you add F.log_softmax(labels) here and make a PR out of it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants