Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-create-metadata in package.json is the wrong version. #18

Closed
sorahn opened this issue Apr 21, 2021 · 3 comments
Closed

grpc-create-metadata in package.json is the wrong version. #18

sorahn opened this issue Apr 21, 2021 · 3 comments

Comments

@sorahn
Copy link

sorahn commented Apr 21, 2021

all the grpc packages were updated to use @grpc/grpc-js, but this installs v3 of create-metadata and not v3.1 so the grpc package which v3 tries to import from is missing.

@sorahn
Copy link
Author

sorahn commented May 3, 2021

@bojand looking at this some more, and I think the versions of grpc-create-metadata needs to depend on which version of Mali you're using. The latest versions of Mail use @grpc/grpc-js which means that in order to use grpc-create-error we need to have the v4 of grpc-create-metadata but that doesn't match the version required by this package.

I think you need to release a v2 of this package that relies on v4 of grpc-create-metadata

@bojand bojand closed this as completed in f020e6f May 30, 2021
@bojand
Copy link
Owner

bojand commented May 30, 2021

should be fixed and published as v2.0.0

@sorahn
Copy link
Author

sorahn commented Jun 2, 2021

Awesome, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants