Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning when no run IDs are linked to aggregate ID #137

Open
adamovanja opened this issue Aug 8, 2022 · 2 comments
Open

Raise warning when no run IDs are linked to aggregate ID #137

adamovanja opened this issue Aug 8, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@adamovanja
Copy link
Contributor

As a plugin user,
I want get-metadata to return a warning or a Q2 error in case one aggregate ID (e.g. BioProject ID, Study ID) of many has no linked run ID entires in the SRA database.

Steps to reproduce:

  • Run get-metadata with an input artifact containing the following accession IDs within: PRJNA290381 & PRJNA18197.

Current behaviour:
get-metadata exits with an empty SRAFailedIDs artifact and the output SRAMetadata only containing metadata of the second accession ID PRJNA18197 and no information on the first accession ID (PRJNA290381) for which no run IDs are linked in the SRA:

2022-08-08 11:06:18,718 [MainThread] [INFO] [entrezpy.conduit.Conduit]: {"querying": {"queryid": "nENHoXsWTd2Q0XdxXQDDSw==", "util": "esearch"}}
2022-08-08 11:06:20,730 [MainThread] [INFO] [entrezpy.conduit.Conduit]: {"querying": {"queryid": "Vq23ZxROQs26_xhKiBLZ1A==", "util": "elink"}}
2022-08-08 11:06:22,740 [MainThread] [INFO] [entrezpy.conduit.Conduit]: {"querying": {"queryid": "vw0N_jJNRoWqb8s_k-2zRA==", "util": "efetch"}}
2022-08-08 11:06:23,747 [MainThread] [INFO] [q2_fondue.metadata]: Fetching metadata for 4 run IDs.
Saved SRAMetadata to: diab_fail/metadata.qza
Saved SRAFailedIDs to: diab_fail/failed_runs.qza

Expected behaviour:
A warning or an error should be raised in case the run IDs of one aggregate ID could not be fetched (by q2_fondue.entrezpy_clients._pipelines._get_run_ids).

@adamovanja adamovanja added the enhancement New feature or request label Aug 8, 2022
@adamovanja adamovanja added this to the Release follow-up 🔜 milestone Aug 8, 2022
@adamovanja
Copy link
Contributor Author

hi @valentynbez,

the error that should appear in your case is not the same one as the one described above: above no error is falsely raised because multiple BioProjectIDs are queried with the get-metadata action and only one of them contains matching runIDs. In your case, you are querying just one BioProjectID with another methods (get-ids-from-query).

Could you open a separate issue for your case?

@valentynbez
Copy link

Hi,

I inspected the error further and yes, it is a separate issue. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants