Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer.json is not compatible with php 7.3 (and so with Magento 2.3.3) #44

Closed
Yonn-Trimoreau opened this issue Oct 9, 2019 · 5 comments
Closed

composer.json is not compatible with php 7.3 (and so with Magento 2.3.3) #44

Yonn-Trimoreau opened this issue Oct 9, 2019 · 5 comments

Comments

@Yonn-Trimoreau
Copy link
Contributor

All is in the title.
I cannot install php 7.3 because your composer.json require php 7.2
Let me make a PR
@Yonn-Trimoreau
Copy link
Contributor Author

#45

@Yonn-Trimoreau
Copy link
Contributor Author

PR merged

@erfanimani
Copy link

Does it actually work with Magento 2.3.3 though?

I'm seeing errors here..

@Yonn-Trimoreau
Copy link
Contributor Author

I did not thoroughly test it actually.
Before this PR, I wasn't even able to test it, that's why I made it.
Maybe you should open another issue with more details about your issue.

@erfanimani
Copy link

No worries — I'll investigate and report back if there are any issues (might be due to our customizations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erfanimani @Yonn-Trimoreau