Check if session is started before accessing #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That voids the check completely. |
|
Yeah, hold this. |
|
@CarsonF I have 🐒 tested this and it seems to work as expected, i.e. if a session cookie is present in the initial request, the session will be restarted so this check is actually valid. I have updated the tests as such, and covered off the deprecated use of |
|
Ah! Because session listener starts the session if precious exists. |
|
Can you remove the isset around session check? It's very non intuitive IMO |
Ha! I can't believe I missed that … Done! |
CarsonF
approved these changes
Dec 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.