Bolt\Storage, Bolt\Events\StorageEvents and Bolt\Content surgery #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwendolenLynch
changed the title
|
Awesome. I suspect this will require a bit of testing, because that part of the code is particularly weird. :-) |
A lot less so now :-) |
contenttype is empty
GwendolenLynch
changed the title
| @@ -99,6 +99,100 @@ public static function getBaseColumns() | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Return a content obejcts values | |||
|
Merging in. I'll fix these two typos all Bill O'Reilly style! |
bobdenotter
added a commit
that referenced
this pull request
Feb 2, 2015
Bolt\Storage, Bolt\Events\StorageEvents and Bolt\Content surgery
|
Not sure if I can't speel or tipe... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, you know when you start looking at a bug like #2484 and you think, "how hard can this be?", and 6 hours later you've fixed the problem... and several others along the way?
Changelog
Fixed: StorageEvents::PRE_SAVE now allows proper on-the-fly modification of data (see #2484)