-
-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush the cache if the Bolt version has changed #3183
Flush the cache if the Bolt version has changed #3183
Conversation
Shouldn't we just tie this to the changes in #3129 ? |
My thought that this case is very lowlevel, fast-path, and provides certain guarantees. Therefore special case. Happy to be over turned though. |
Oh wait, I think I might have misunderstood your point… pinging you on IRC in 5… 4… 3… |
Nah, I guess you're right.. This does allow us to remove the "… and flush the cache." from the notice that we set in #3129, though. |
Yeah, I might append this to do exactly that then. |
Updated! 🎉 |
Heh. I sort of meant only the "clear the cache" part. The notice itself is a 'feature', to reassure the user: "Hey, we noticed you've update! Good job, old chap. Ta ta!".. something like that. ;-) |
Derp derp derp derp… With added derp. |
handle the cache flush and link it for them
Can I also suggest we back port this to |
Merging in, and will cherry-pick into release/2.1 |
Flush the cache if the Bolt version has changed
Fixes #3182