Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush the cache if the Bolt version has changed #3183

Merged
merged 2 commits into from
Mar 19, 2015
Merged

Flush the cache if the Bolt version has changed #3183

merged 2 commits into from
Mar 19, 2015

Conversation

GwendolenLynch
Copy link
Contributor

Fixes #3182

@bobdenotter
Copy link
Member

Shouldn't we just tie this to the changes in #3129 ?

@GwendolenLynch
Copy link
Contributor Author

My thought that this case is very lowlevel, fast-path, and provides certain guarantees. Therefore special case. Happy to be over turned though.

@GwendolenLynch
Copy link
Contributor Author

Oh wait, I think I might have misunderstood your point… pinging you on IRC in 5… 4… 3…

@bobdenotter
Copy link
Member

Nah, I guess you're right.. This does allow us to remove the "… and flush the cache." from the notice that we set in #3129, though.

@GwendolenLynch
Copy link
Contributor Author

Yeah, I might append this to do exactly that then.

@GwendolenLynch
Copy link
Contributor Author

Updated! 🎉

@bobdenotter
Copy link
Member

Heh. I sort of meant only the "clear the cache" part. The notice itself is a 'feature', to reassure the user: "Hey, we noticed you've update! Good job, old chap. Ta ta!".. something like that. ;-)

@GwendolenLynch
Copy link
Contributor Author

Heh. I sort of meant only the "clear the cache" part. The notice itself is a 'feature', to reassure the user:

Derp derp derp derp… With added derp.

@GwendolenLynch
Copy link
Contributor Author

Can I also suggest we back port this to release/2.1 as that is where it is currently hitting installs.

@bobdenotter
Copy link
Member

Merging in, and will cherry-pick into release/2.1

bobdenotter added a commit that referenced this pull request Mar 19, 2015
Flush the cache if the Bolt version has changed
@bobdenotter bobdenotter merged commit ad1a51d into bolt:master Mar 19, 2015
@GwendolenLynch GwendolenLynch deleted the feature/cache-version-flush branch March 19, 2015 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants