Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for remote file opening when connecting to other than 'localhost' #117

Open
boltex opened this issue Oct 24, 2020 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@boltex
Copy link
Owner

boltex commented Oct 24, 2020

Support remote file opening to stabilize usage from connections coming from outside of 'localhost'.

For now, LeoInteg "open-file browser" is just vscode's utility 'open-file-dialog', that offers to choose locally. A remote server would not see the chosen file, and fail opening anything.

TODO:

1- Differentiate connection IP to detect if not connected to localhost
Use when:
a) calling 'open file' command.
b) when trying to reopen last opened files at startup.
c) Also block/allow opening local Leo files with right click in explorer.

2- Offer remote files selection dialog when open file command executes with remote.

3- Modify startup procedure to prevent opening last opened local files if connecting to a remote server. (Maybe save recent files with server address association, to only try to reopen those where connection address match with the right method).

@boltex boltex added the enhancement New feature or request label Oct 24, 2020
@boltex boltex self-assigned this Oct 24, 2020
@boltex
Copy link
Owner Author

boltex commented Oct 28, 2020

Also needs to continue listening for subsequent connections after a "client disconnect" is detected, instead of exiting script.

@boltex
Copy link
Owner Author

boltex commented Mar 10, 2021

@edreamleo This is also an indirect issue for leoserver now part of the Leo project itself. I'll add more descriptive details about this when I convert leoInteg to specifically use leoserver from the Leo editor instead of the old leoBridgeServer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant