Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Command Buttons: Change Way Title Is Computed #169

Open
tbpassin opened this issue Jul 20, 2021 · 2 comments
Open

Adding Command Buttons: Change Way Title Is Computed #169

tbpassin opened this issue Jul 20, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request Not Sure... Maybe not an issue
Milestone

Comments

@tbpassin
Copy link

When leointeg creates a button from a script node, it copies the node's headline as the button title, with some truncation. Some of the scripts I want to turn onto a button start with @command. The button title should not include strings like that since they take up space and obscure the meaning. E.g., a node whose headline is:

@command change-widget-by-this-very-long-command @key=ctrl-x

should have a button title like:

change-widget-by-this-very-long-co

So please:

  1. Remove Leo directives from button titles;
  2. Truncate button titles to a longer length. There is plenty of potential length available.
@boltex
Copy link
Owner

boltex commented Jul 20, 2021

Thanks for noticing this! Will do! 😁

@boltex boltex self-assigned this Jul 21, 2021
@boltex boltex added enhancement New feature or request Not Sure... Maybe not an issue labels Jul 21, 2021
@boltex
Copy link
Owner

boltex commented Jul 23, 2021

After fixing #173 and #178, I tried what happens with that in plain old Leo (thinking I was about to fix this issue too along with those other two...) : Turns out it's exactly the same as in Leo! ... Meaning that Leo gives me the names like that..! heh...

So I'll leave it like this for now, and by the way, buttons created this way are 'cleaned up' of directives, so this only applies to '@commands'.

Maybe I'll get @edreamleo 's input later to see if it should be changed in Leo, if anywhere.

@edreamleo edreamleo added this to the 1.1 milestone Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Not Sure... Maybe not an issue
Projects
None yet
Development

No branches or pull requests

3 participants