Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some commands do not support 'Undo' #45

Closed
boltex opened this issue Jun 10, 2020 · 0 comments
Closed

Some commands do not support 'Undo' #45

boltex opened this issue Jun 10, 2020 · 0 comments
Assignees
@boltex
Labels
bug Something isn't working

Comments

@boltex
Copy link
Owner

boltex commented Jun 10, 2020 •
edited
Loading

This can be fixed by altering only leobridgeserver.py (from editing its leo file: leoInteg.leo)

UNDO operation works with outline changes such as move node commands, but some others (insert node, rename node and maybe others..) seem to need to set an 'undo' restore point when being executed.

See class Undoer in leoUndo.py from Leo's sources for relevant methods to be called for this fix.
@boltex boltex added bug Something isn't working enhancement New feature or request labels Jun 10, 2020
@boltex boltex self-assigned this Jun 10, 2020
@boltex boltex removed the enhancement New feature or request label Jun 10, 2020
@boltex boltex mentioned this issue Jun 12, 2020
Merged
@boltex boltex closed this as completed in 52f042e Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boltex boltex

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boltex