Refactor default serial port implementation to avoid event callbacks #1444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the default serial port implementation to avoid relying on the
DataReceived
event. Besides being prone to deadlock on dispose as observed in #1437, the event callbacks for serial port are not available in several implementations, including Mono and Unity3D.The new implementation uses directly the serial port stream through dedicated service threads that perform blocking reads. These can be interrupted asynchronously by directly calling
Dispose
from a separate thread, so they afford synchronized disposal without any additional logic. Furthermore, this approach establishes an initial exploration for later generalizing asynchronous line reads over any stream, which can be useful for streaming data from files, network sockets and other data sources.