Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Webhook is not validating deletion of objects #324

Open
hihilla opened this issue May 28, 2020 · 0 comments
Open

Webhook is not validating deletion of objects #324

hihilla opened this issue May 28, 2020 · 0 comments

Comments

@hihilla
Copy link
Contributor

hihilla commented May 28, 2020

Shipper's validating webhook does not validate a delete action. This allows users to delete objects when there is a rollout block in the system, and Shipper will not process this properly.
For example, there is a rollout block in the system. A user deletes a release, but the parent application is not overriding this release. Shipper will not process the application since it is blocked, but all objects with owner reference pointing to the deleted release will be deleted. This causes pods to drop, without spinning new pods.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant