Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomTask Submit #244

Open
AndreiOla opened this issue Nov 3, 2022 · 2 comments
Open

CustomTask Submit #244

AndreiOla opened this issue Nov 3, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AndreiOla
Copy link
Contributor

Describe the bug
Why we are stting workspaces twice?

To Reproduce
Review code.

Expected behavior
Do not overwrite values.

Additional context
In ControllerClientImpl.java -> submitCustomTask(...) there are these lines of code:

253    List<TaskWorkspace> taskWorkspaces = buildTaskWorkspaceList(workflow, activityId);
254   request.setWorkspaces(taskWorkspaces);
*****************
294     request.setWorkspaces(activity.getTaskWorkspaces());

Is there a reason for this or this is a bug?

@AndreiOla AndreiOla added the bug Something isn't working label Nov 3, 2022
@gchickma
Copy link
Member

gchickma commented Nov 8, 2022

@amhudson @marcusdroy Please let me know when you have had a chance to look at this bug. Thx.

@amhudson
Copy link
Member

amhudson commented Nov 8, 2022

lines 253-254 look to be correct. @marcusdroy is there a reason for line 294?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants