Rubocop, RSpec, and deprecation warning for serialize method

Author: richardmatthewsdev

app/models/pipeline_job.rb

@@ -3,7 +3,7 @@
 class PipelineJob < ApplicationRecord
   include Job
 
-  serialize :harvest_definitions_to_run, Array
+  serialize :harvest_definitions_to_run, type: Array
 
   belongs_to :pipeline
   belongs_to :extraction_job, optional: true

app/models/schedule.rb

@@ -5,7 +5,7 @@ class Schedule < ApplicationRecord
   belongs_to :destination
   has_many   :pipeline_jobs, dependent: :nullify
 
-  serialize :harvest_definitions_to_run, Array
+  serialize :harvest_definitions_to_run, type: Array
 
   validates :name,                       presence: true, uniqueness: true
   validates :frequency,                  presence: true

app/supplejack/extraction/documents.rb

@@ -33,8 +33,8 @@ def in_bounds?(current_page)
     end
 
     def documents_filepath
-      @documents_filepath ||= Dir.glob("#{@folder}/*.json").sort_by do |page| 
-        page.match(/__(?<record_id>.+)__(?<page>.+).json/)[:page].to_i 
+      @documents_filepath ||= Dir.glob("#{@folder}/*.json").sort_by do |page|
+        page.match(/__(?<record_id>.+)__(?<page>.+).json/)[:page].to_i
       end
     end
   end

spec/sidekiq/text_extraction_worker_spec.rb

@@ -10,7 +10,7 @@
   describe "#perform" do
     context 'when the PDF extraction is not part of a harvest' do
       before do
-        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example.json")
+        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example__1234__01.json")
       end
 
       it 'converts a PDF into raw text' do
@@ -36,7 +36,7 @@
       it 'names the new files following as it was originally' do
         TextExtractionWorker.new.perform(extraction_job.id)
 
-        expect(File.exist?("#{extraction_job.extraction_folder}/example.json")).to eq(true)
+        expect(File.exist?("#{extraction_job.extraction_folder}/example__1234__01.json")).to eq(true)
       end
 
       it 'does not enqueue Transformation Workers' do
@@ -48,7 +48,7 @@
 
     context 'when the PDF extraction is part of a harvest' do
       before do
-        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example.json")
+        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example__1234__01.json")
       end
 
       let!(:harvest_report)    { create(:harvest_report, pipeline_job:, harvest_job:) }
@@ -77,7 +77,7 @@
 
     context 'when the PDF extraction is part of an enrichment' do
       before do
-        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example__1234__.json")
+        FileUtils.cp("#{Rails.root}/spec/support/example.pdf", "#{extraction_job.extraction_folder}/example__1234__01.json")
       end
 
       let(:destination) { create(:destination) }